Remove unnecessary static modifier #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it were only me, I'd accept cosmetic changes such as this, but history tells me not to. |
|
@akarnokd why? Sad that I understand that RxJava is not "my project" and I can't just come and force you to use "my codestyle" (which is actually just standard java codestyle), so if you don't want to accept such changes — it's okay, I'll stop doing such PRs and will report only major issues. |
|
I like this PR too much, I'm going to merge it ;) |
akarnokd
added a commit
that referenced
this pull request
Aug 12, 2015
…difier Remove unnecessary static modifier
:-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.S.
@benjchristensen @akarnokd sorry for large amount of simple pull requests, I'm doing full code review of RxJava sources http://artemzin.com/blog/rxjava-code-review-part-1/ and I'll create PRs and issues during this review.
I'll try to group changes by themes so it will be easy to review them. Looks like this adventure is going to be part of #3145!