Observers package test coverage and fixes. #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public class ObserversTest { | ||
| @Test | ||
| public void testNotInstantiable() { |
There was a problem hiding this comment.
Nice, I'll submit PR with nice class which allows test private constructors if you don't mind.
akarnokd
force-pushed
the
TestCoverageObservers
branch
from
27fb4b7
to
2423a17
Compare
akarnokd
added a commit
that referenced
this pull request
Aug 12, 2015
Observers package test coverage and fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a rewrite of
SerializedObserverto have a more cleaner exception semantics.The
TestSubscriberTestcan be improved further but I've run out of time for today.