Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Troubleshoot Angular Material breakage with "do not write @-bound properties" commit #12259

Closed
jeffbcross opened this issue Jul 2, 2015 · 0 comments
Closed

Troubleshoot Angular Material breakage with "do not write @-bound properties" commit #12259

jeffbcross opened this issue Jul 2, 2015 · 0 comments
Labels
component: $compile origin: google severity: regression
Milestone
1.4.4

Comments

@jeffbcross
Copy link
Contributor

Troubleshoot Angular Material breakage with 8a1eb16, which was reverted.

This spec is failing: https://github.com/angular/material/blob/786b0ed3652b7460c2c802efa1aa79972bd96f5d/src/components/chips/contact-chips.spec.js#L46

With this error:

Error: [$compile:nonassign] Expression '' used with directive 'mdAutocomplete' is non-assignable!
    http://errors.angularjs.org/1.4.2-build.4088+sha.4da1cc3/$compile/nonassign?p0=&p1=mdAutocomplete
    minErr/<@/material/temp/angular.js:68:12
    initializeDirectiveBindings/</parentSet<@/material/temp/angular.js:8705:1
    parentValueWatch@/material/temp/angular.js:8718:19
    regularInterceptedExpression@/material/temp/angular.js:14227:16
    constantWatch@/material/temp/angular.js:14208:16
    $RootScopeProvider/this.$get</Scope.prototype.$digest@/material/temp/angular.js:15674:34
    $RootScopeProvider/this.$get</Scope.prototype.$apply@/material/temp/angular.js:15950:13
    buildChips/<@/material/src/components/chips/contact-chips.spec.js:98:7
    invoke@/material/temp/angular.js:4452:14
    workFn@/material/temp/angular-mocks.js:2420:11
    angular.mock.inject@/material/temp/angular-mocks.js:2392:30
    buildChips@/material/src/components/chips/contact-chips.spec.js:96:5
    @/material/src/components/chips/contact-chips.spec.js:51:23
    invoke@/material/temp/angular.js:4452:14
    workFn@/material/temp/angular-mocks.js:2420:11

    angular.mock.inject@/material/temp/angular-mocks.js:2391:25
    buildChips@/material/src/components/chips/contact-chips.spec.js:96:5
    @/material/src/components/chips/contact-chips.spec.js:51:23
    invoke@/material/temp/angular.js:4452:14
    workFn@/material/temp/angular-mocks.js:2420:11

    angular.mock.inject@/material/temp/angular-mocks.js:2391:25
    @/material/src/components/chips/contact-chips.spec.js:46:27
    jasmineInterface.describe@/material/node_modules/karma-jasmine/lib/boot.js:59:14
    @/material/src/components/chips/contact-chips.spec.js:45:5
    jasmineInterface.describe@/material/node_modules/karma-jasmine/lib/boot.js:59:14
    @/material/src/components/chips/contact-chips.spec.js:36:3
    jasmineInterface.describe@/material/node_modules/karma-jasmine/lib/boot.js:59:14
    @/material/src/components/chips/contact-chips.spec.js:1:1

CC @ThomasBurleson @caitp
@Narretz Narretz added this to the 1.4.2 milestone Jul 6, 2015
@petebacondarwin petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015
@Narretz Narretz mentioned this issue Jul 7, 2015
Closed
caitp added a commit to caitp/angular.js that referenced this issue Jul 7, 2015
@caitp
fix($compile): ignore optional =-bound properties with empty value
7c311bf 
Previously, optional empty '='-bound expressions were ignored ---
erroneously they stopped being ignored, and no tests were caused to
fail for this reason. This change restores the original ignoring
behaviour while still preventing other errors fixed by 8a1eb16

Closes angular#12144
Closes angular#12259
@caitp caitp mentioned this issue Jul 7, 2015
Closed
caitp added a commit to caitp/angular.js that referenced this issue Jul 7, 2015
@caitp
fix($compile): ignore optional =-bound properties with empty value
df73233 
Previously, optional empty '='-bound expressions were ignored ---
erroneously they stopped being ignored, and no tests were caused to
fail for this reason. This change restores the original ignoring
behaviour while still preventing other errors fixed by 8a1eb16

Closes angular#12144
Closes angular#12259
@matsko matsko modified the milestones: 1.4.3, 1.4.4 Jul 14, 2015
@caitp caitp closed this as completed in 533d9b7 Jul 29, 2015
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@caitp @netman92
fix($compile): ignore optional =-bound properties with empty value
b745289 
Previously, optional empty '='-bound expressions were ignored ---
erroneously they stopped being ignored, and no tests were caused to
fail for this reason. This change restores the original ignoring
behaviour while still preventing other errors fixed by 8a1eb16

Closes angular#12144
Closes angular#12259
Closes angular#12290
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@caitp @petebacondarwin
fix($compile): ignore optional =-bound properties with empty value
7ec4ae8 
Previously, optional empty '='-bound expressions were ignored ---
erroneously they stopped being ignored, and no tests were caused to
fail for this reason. This change restores the original ignoring
behaviour while still preventing other errors fixed by 8a1eb16

Closes angular#12144
Closes angular#12259
Closes angular#12290
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: $compile origin: google severity: regression
Projects
None yet
Milestone
1.4.4
Development

Successfully merging a pull request may close this issue.

fix($compile): ignore optional =-bound properties with empty value caitp/angular.js
4 participants
@petebacondarwin @matsko @jeffbcross @Narretz