Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If attach Nic failed in libvirt attach stage, the allocated ip will not return to database #76

Closed
youyk opened this issue Jul 20, 2015 · 2 comments
Closed

If attach Nic failed in libvirt attach stage, the allocated ip will not return to database #76

youyk opened this issue Jul 20, 2015 · 2 comments
Assignees
@zxwing
Labels
bug invalid
Milestone
0.8

Comments

@youyk
Copy link
Contributor

youyk commented Jul 20, 2015

No stable way to produce libvirt attach failure, but better to check the logic of rollback for attach nic failure not release ip issue.
@youyk youyk added the bug label Jul 20, 2015
@youyk youyk added this to the 0.8 milestone Jul 20, 2015
@zxwing zxwing added the invalid label Jul 20, 2015
@zxwing
Copy link
Contributor

zxwing commented Jul 20, 2015

how do you confirm this? The rollback logic is correct and the unit test TestAttachNicOnKvm2 guarantee this.

@zxwing
Copy link
Contributor

zxwing commented Jul 24, 2015

fixed in upstream.

@zxwing zxwing closed this as completed Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxwing zxwing

Labels
bug invalid
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
2 participants
@zxwing @youyk