Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide per page option for manipulating NavigationBar #263

Closed
hshristov opened this issue Jun 2, 2015 · 4 comments
Closed

Provide per page option for manipulating NavigationBar #263

hshristov opened this issue Jun 2, 2015 · 4 comments
Assignees
@hamorphis
Labels
done feature severity: low
Milestone
1.2.0

Comments

@hshristov
Copy link
Contributor

Page should have setting that specifies navigationBar visibility.
@hshristov hshristov added this to the 1.2.0 milestone Jun 2, 2015
@hshristov hshristov modified the milestones: 1.2.0, 1.2.0 (Under Review) Jun 10, 2015
@hamorphis hamorphis self-assigned this Jun 30, 2015
hamorphis added a commit that referenced this issue Jul 1, 2015
@hamorphis
Resolved issue #263
4d30170
@hamorphis hamorphis added ready for test TSC needs to test this and confirm against live production apps and automated test suites and removed in progress labels Jul 1, 2015
@hamorphis
Copy link
Contributor

The new property is called Page.navigationBarHidden.

hamorphis added a commit that referenced this issue Jul 1, 2015
@hamorphis
Merge pull request #375 from NativeScript/issue-263
a422994 
Resolved issue #263
@vchimev vchimev mentioned this issue Jul 3, 2015
Closed
@vchimev vchimev removed the backlog label Jul 15, 2015
@vchimev
Copy link
Contributor

vchimev commented Jul 16, 2015

Current state issues:

  • iOS - when Page.navigationBarHidden = true the page is layouted as the navigation bar is hidden, but it is preset on the page and covers its content.
  • Android - when Page.navigationBarHidden = true the page is layouted as expected, but going to another page where action bar should be present - it is not.

@vakrilov vakrilov mentioned this issue Jul 16, 2015
Merged
@vchimev vchimev added done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Jul 20, 2015
@vchimev
Copy link
Contributor

vchimev commented Jul 20, 2015

The property is renamed to Page.actionBarHidden. Issues fixed.

@vchimev vchimev closed this as completed Jul 20, 2015
@lock
Copy link

lock bot commented Aug 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hamorphis hamorphis

Labels
done feature severity: low
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@hamorphis @hshristov @vchimev