Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional fullscreen parameter to Page.showModal method. #294

Closed
hamorphis opened this issue Jun 8, 2015 · 1 comment
Closed

Add an optional fullscreen parameter to Page.showModal method. #294

hamorphis opened this issue Jun 8, 2015 · 1 comment
Assignees
@hamorphis
Labels
done feature severity: medium
Milestone
1.2.0

Comments

@hamorphis
Copy link
Contributor

Allow specifying whether the modal pages are shown in full-screen or not, i.e.

showModal(moduleName: string, context: any, closeCallback: Function, fullscreen?: boolean);
@hamorphis hamorphis self-assigned this Jun 8, 2015
@hamorphis hamorphis added this to the 1.2.0 milestone Jun 8, 2015
@hshristov hshristov modified the milestones: 1.2.0, 1.2.0 (Under Review) Jun 10, 2015
@hshristov hshristov added the P:3 label Jun 10, 2015
@hamorphis hamorphis added ready for test TSC needs to test this and confirm against live production apps and automated test suites and removed in progress labels Jun 11, 2015
hamorphis added a commit that referenced this issue Jun 11, 2015
@hamorphis
Resolved #294: Add an optional fullscreen parameter to Page.showModal…
1560789 
… method.
@vchimev vchimev added done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Jun 29, 2015
@lock
Copy link

lock bot commented Aug 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hamorphis hamorphis

Labels
done feature severity: medium
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@hamorphis @hshristov @vchimev