Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the typo for audit table (type, created_date) index creation #1322

Merged
merged 1 commit into from
Apr 30, 2015

Conversation

himanshug
Copy link
Contributor

This PR fixes keys of an index in the audit table. Anyone migrating from previous versions of druid-0.7.x would need to execute following sql on their database.

<table_name> = "druid_audit" (by default) or value of property "druid.metadata.storage.tables.audit" from your druid configuration

mysql:

ALTER TABLE <table_name> DROP INDEX idx_<table_name>_type_time;
CREATE INDEX idx_<table_name>_type_time ON <table_name>(type, created_date);

postgres:

DROP INDEX idx_<table_name>_type_time;
CREATE INDEX idx_<table_name>_type_time ON <table_name>(type, created_date);

@xvrl
Copy link
Member

xvrl commented Apr 29, 2015

can we write some instructions somewhere on how to fix this, that we'll include in the release notes, so people can fix their tables when upgrading?

@himanshug
Copy link
Contributor Author

@xvrl I've update PR description with migration steps required.

I have tested those for mysql. dint have a postgres installation so couldn't test. Can someone please validate the steps for postgres? thanks.

@fjy
Copy link
Contributor

fjy commented Apr 30, 2015

@himanshug can you test postgresql locally?

@himanshug
Copy link
Contributor Author

@fjy ok, I checked the steps on a locally installed postgres server and steps shown in the PR description worked just fine.

@fjy
Copy link
Contributor

fjy commented Apr 30, 2015

@himanshug Thanks!

fjy added a commit that referenced this pull request Apr 30, 2015
fixing the typo for audit table (type, created_date) index creation
@fjy fjy merged commit 15ed308 into apache:master Apr 30, 2015
@himanshug himanshug deleted the fix_audit_tbl_idx branch May 16, 2015 22:41
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants