This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
feat(router): add Diffie-Hellman parameter for DHE ciphersuites #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzowski
force-pushed
the
feature/dhparam
branch
from
d802e11
to
dac0663
Compare
wenzowski
changed the title
|
Code LGTM. |
|
So this will simply allow admins to define parameters for their Ephemeral DH generation? AFAIK, numbits is the only thing you can set for this, right? I'm good with that. LGTM |
|
@technosophos yes numbits is the only required param |
carmstrong
added a commit
that referenced
this pull request
Jun 18, 2015
feat(router): add Diffie-Hellman parameter for DHE ciphersuites
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openssl defaults for Ephemeral Diffie-Hellman exchange are considered by some to be inadequate.
Generate a 2048-bit key and upload to the cluster with: