revwalk: don't insert uninteresting commits into the queue

When a commit is first set as unintersting and then pushed, we must take care that we do not put it into the commit list as that makes us return at least that commit (but maybe more) as we've inserted it into the list because we have the assumption that we want anything in the commit list.
libgit2 · May 18, 2015 · 702ac40 · 702ac40
1 parent 98e484b
commit 702ac40
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/revwalk.c b/src/revwalk.c
@@ -162,6 +162,10 @@ static int push_commit(git_revwalk *walk, const git_oid *oid, int uninteresting,
 	if (commit == NULL)
 		return -1; /* error already reported by failed lookup */
 
+	/* A previous hide already told us we don't want this commit  */
+	if (commit->uninteresting)
+		return 0;
+
 	if (uninteresting)
 		walk->did_hide = 1;
 	else