Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] [BUG] fix doesn't correct column domain #10439

Merged
merged 1 commit into from Jun 2, 2015

Conversation

KorsaR-ZN
Copy link
Contributor

2.0.2

$table1 = new \Models\Table1();
$table2 = new \Models\Table2();

$readConnection = $table1->getReadConnection();

$builder = new \Phalcon\Mvc\Model\Query\Builder();
$builder->from(get_class($table1))
   ->addFrom(get_class($table2), 't2');

echo $readConnection->getDialect()->select($builder->getQuery()->parse());

Outputs

SELECT `models\Table1`.*, `t2`.* FROM `table1`, `table2` AS `t2`

2.0.3 (after merge)

Outputs

SELECT `table1`.*, `t2`.* FROM `table1`, `table2` AS `t2`

@andresgutierrez
Copy link
Sponsor Contributor

This needs to be rebased

@KorsaR-ZN
Copy link
Contributor Author

@andresgutierrez rebase

@KorsaR-ZN KorsaR-ZN closed this May 31, 2015
@KorsaR-ZN KorsaR-ZN reopened this May 31, 2015
andresgutierrez added a commit that referenced this pull request Jun 2, 2015
[2.0.x] [BUG] fix doesn't correct column domain
@andresgutierrez andresgutierrez merged commit e18e790 into phalcon:2.0.x Jun 2, 2015
@andresgutierrez
Copy link
Sponsor Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants