Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.changed() detects value as changed when set from null to null. #3812

Closed
JrSchild opened this issue May 27, 2015 · 2 comments
Closed

.changed() detects value as changed when set from null to null. #3812

JrSchild opened this issue May 27, 2015 · 2 comments
Labels
type: bug

Comments

@JrSchild
Copy link

If the value of an instance was null and is .set() to null, Sequelize detects the value as changed.
Using sequelize 3.1.1.
@Thomathan
Copy link

instance.js has a primitives array and only compares values that match it. Since null is a primitive it should be included as well.

However, typeof null returns object which seems to be bug in ecmascript.

Will probably need to explicitly check for null.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/null
http://www.ecma-international.org/ecma-262/5.1/#sec-4.3.2
http://www.ecma-international.org/ecma-262/5.1/#sec-4.3.11

@JrSchild
Copy link
Author

Thank you for the fast response. I can confirm that it fixes the issue.

mickhansen added a commit that referenced this issue May 28, 2015
@mickhansen
Merge pull request #3817 from BridgeAR/master
31133a6 
Fix two minor issues. Closes #3812 and #3770
IrfanBaqui pushed a commit to IrfanBaqui/sequelize that referenced this issue Jun 24, 2015
Fix two minor issues. Closes sequelize#3812 and sequelize#3770
87c0e3c
IrfanBaqui pushed a commit to IrfanBaqui/sequelize that referenced this issue Jun 24, 2015
@mickhansen
Merge pull request sequelize#3817 from BridgeAR/master
9701f45 
Fix two minor issues. Closes sequelize#3812 and sequelize#3770
@Thomathan Thomathan mentioned this issue Dec 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JrSchild @mickhansen @Thomathan