Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreloadTargets call to clear() is ignored #385

Closed
sjudd opened this issue Mar 30, 2015 · 0 comments
Closed

PreloadTargets call to clear() is ignored #385

sjudd opened this issue Mar 30, 2015 · 0 comments
Labels
bug
Milestone
3.6.0

Comments

@sjudd
Copy link
Collaborator

sjudd commented Mar 30, 2015

When clear() is called, the resource isn't yet set in SingleRequest, so the reference count is not decremented. This results in failure to re-use resources unless users happen to be clearing more often than strictly necessary (ie a call to clear() in a RecyclerListener)
@sjudd sjudd added the bug label Mar 30, 2015
@sjudd sjudd added this to the 3.6.0 milestone Mar 30, 2015
@sjudd sjudd closed this as completed in 0290100 Apr 1, 2015
sjudd added a commit to sjudd/glide that referenced this issue Apr 1, 2015
@sjudd
Set resource before notifying listeners so requests can be cleared by…
38853b6 
… Targets

Rollforward of [] external bug for 352 is: bumptech#385.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=89916328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.6.0
Development

No branches or pull requests
1 participant
@sjudd