Crash when mutating SquaringDrawable (getConstantState is not overridden) - v3.5.2 #349
Comments
alex2069
changed the title
|
Thanks for the report, any chance you can add a few lines of example code that will reproduce the problem? |
|
MainActivity @Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.main_activity);
final ImageView imgView = (ImageView) findViewById(R.id.main_img);
imgView.setColorFilter(new PorterDuffColorFilter(Color.RED, PorterDuff.Mode.MULTIPLY));
findViewById(R.id.main_click_to_crash).setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
Uri uri = Uri.parse("http://upload.wikimedia.org/wikipedia/commons/thumb/d/dd/Square_-_black_simple.svg/200px-Square_-_black_simple.svg.png");
Glide.with(MainActivity.this)
.load(uri)
.placeholder(R.drawable.glide_logo)
.into(imgView);
}
});
}Layout <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
android:paddingTop="@dimen/activity_vertical_margin"
android:paddingBottom="@dimen/activity_vertical_margin"
tools:context=".MainActivity"
android:orientation="vertical">
<Button
android:id="@+id/main_click_to_crash"
android:layout_width="100dp"
android:text="Click to crash"
android:layout_height="wrap_content"
tools:ignore="HardcodedText"/>
<ImageView
android:id="@+id/main_img"
android:layout_width="100dp"
android:layout_height="100dp"
android:contentDescription="@null"/>
</LinearLayout>The Here is a demo project: https://www.dropbox.com/s/6yg6zk5qt3ibp95/glide-mutate-crash.zip?dl=0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If an ImageView has something that has its (internal)
mColorModfield set to true (i.e. there is an alpha or color filter set - seeImageView.applyColorMod()), then when Glide updates the image view providing theTransitionDrawable(the current drawable +SquaringDrawable), the image view attempts to mutate it and crashes (NPE) when callingSquaringDrawable.getConstantState().Trace from Genymotion v4.4.2
The text was updated successfully, but these errors were encountered: