Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker multi-node #6505

Merged
merged 2 commits into from Apr 8, 2015
Merged

Docker multi-node #6505

merged 2 commits into from Apr 8, 2015

Conversation

brendandburns
Copy link
Contributor

Definitely a work in progress, please don't merge, but sending out for review/comments.

We should think about collapsing all non-core getting started examples down to this approach.


```sh
sudo docker run --net=host -d -v /var/run/docker.sock:/var/run/docker.sock gcr.io/google_containers/hyperkube:v0.14.1 /hyperkube kubelet --api_servers=http://${MASTER_IP}:8080 --v=2 --address=0.0.0.0 --enable_server --hostname_override=$(hostname -i)
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan on using hostname here the user must ensure DNS is setup correctly. This won't be the case in a lot of environments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hostname -i gives the ip address (or at least on my Debian box it does...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@kelseyhightower
Copy link
Contributor

This guide looks great and I'm +1 on making all non-core examples follow this approach. This pattern should work for all platforms and can be automated if people prefer that, but this guide should keep the step-by-step details so others can understand what's happening.

_Note_: These instructions are somewhat significantly more advanced than the [single node](docker.md) instructions. If you are
interested in just starting to explore Kubernetes, we recommend that you start there.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be helpful to add a note about the setup and pattern here: The following guide will make use of two docker daemons, a pattern which will allow us to manage and deploy "system" services such as flannel and etcd in containers...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of this guide you will have a setup that supports adding additional worker nodes after the initial bootstrapping process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@brendandburns
Copy link
Contributor Author

@kelseyhightower comments addressed. Thanks for the feedback. Please take another look.

(I'm probably going to break this into multiple pages for easier readability.)

--brendan

@kelseyhightower
Copy link
Contributor

@brendanburns LGTM. I like where things are headed with this pattern.

@yllierop
Copy link
Contributor

yllierop commented Apr 7, 2015

LGTM great work @brendanburns

@brendandburns brendandburns force-pushed the hyperkube branch 10 times, most recently from 8718fa6 to b3c46b5 Compare April 8, 2015 04:21
@brendandburns
Copy link
Contributor Author

Ok, I broke this up into separate pages. I'm happy with the layout now. I also double checked that the instructions worked correctly on GCE + Debian. Should work elsewhere as well.

This is ready to merge.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2015
vishh added a commit that referenced this pull request Apr 8, 2015
@vishh vishh merged commit ffffbb7 into kubernetes:master Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants