New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker multi-node #6505
Docker multi-node #6505
Conversation
|
||
```sh | ||
sudo docker run --net=host -d -v /var/run/docker.sock:/var/run/docker.sock gcr.io/google_containers/hyperkube:v0.14.1 /hyperkube kubelet --api_servers=http://${MASTER_IP}:8080 --v=2 --address=0.0.0.0 --enable_server --hostname_override=$(hostname -i) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we plan on using hostname here the user must ensure DNS is setup correctly. This won't be the case in a lot of environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hostname -i
gives the ip address (or at least on my Debian box it does...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
This guide looks great and I'm +1 on making all non-core examples follow this approach. This pattern should work for all platforms and can be automated if people prefer that, but this guide should keep the step-by-step details so others can understand what's happening. |
_Note_: These instructions are somewhat significantly more advanced than the [single node](docker.md) instructions. If you are | ||
interested in just starting to explore Kubernetes, we recommend that you start there. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be helpful to add a note about the setup and pattern here: The following guide will make use of two docker daemons, a pattern which will allow us to manage and deploy "system" services such as flannel and etcd in containers...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end of this guide you will have a setup that supports adding additional worker nodes after the initial bootstrapping process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@kelseyhightower comments addressed. Thanks for the feedback. Please take another look. (I'm probably going to break this into multiple pages for easier readability.) --brendan |
@brendanburns LGTM. I like where things are headed with this pattern. |
LGTM great work @brendanburns |
8718fa6
to
b3c46b5
Compare
Ok, I broke this up into separate pages. I'm happy with the layout now. I also double checked that the instructions worked correctly on GCE + Debian. Should work elsewhere as well. This is ready to merge. |
Definitely a work in progress, please don't merge, but sending out for review/comments.
We should think about collapsing all non-core getting started examples down to this approach.