function_score: undo "Remove explanation of query score from functions" #9826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the Explanation to the explain score again. It is needed because the explanation of script functions will otherwise not contain an explanation of _score if boost mode is set to replace.
| return new Explanation((float) (runAsDouble()), "This script returned " + runAsDouble()); | ||
| public Explanation explain(Explanation subQueryScore) throws IOException { | ||
| Explanation exp = new Explanation((float) (runAsDouble()), "This script returned " + runAsDouble()); | ||
| Explanation _scoreExp = new Explanation(subQueryScore.getValue(), "_score: "); |
There was a problem hiding this comment.
Can you remove the leading underscore? Variables should start with a lowercase letter according to http://www.oracle.com/technetwork/java/codeconventions-135099.html
|
LGTM |
| @@ -86,6 +88,7 @@ public void testNativeExplainScript() throws InterruptedException, IOException, | |||
| for (SearchHit hit : hits.getHits()) { | |||
| assertThat(hit.getId(), equalTo(Integer.toString(idCounter))); | |||
| assertThat(hit.explanation().toString(), containsString(Double.toString(idCounter) + " = This script returned " + Double.toString(idCounter))); | |||
| assertThat(hit.explanation().toString(), containsString("1.0 = tf(freq=1.0), with freq of")); | |||
There was a problem hiding this comment.
To prevent future changes from removing the nesting, we could add for example
assertThat(hit.explanation().getDetails().length, equalTo(2));
or something even more explicit.
@brwe WDYT?
|
👍 |
|
Can we expect this to be in version 1.4.5? |
|
@brwe LGTM |
|
@brwe please merge this into 1.x, 1.5 and master |
brwe
added a commit
that referenced
this pull request
Mar 24, 2015
This adds the Explanation to the explain score again. It is needed because the explanation of script functions will otherwise not contain an explanation of _score if boost mode is set to replace. closes #9826
brwe
added a commit
that referenced
this pull request
Mar 24, 2015
This adds the Explanation to the explain score again. It is needed because the explanation of script functions will otherwise not contain an explanation of _score if boost mode is set to replace. closes #9826
|
@maxjakob sorry we did not get this in 1.5 and promised I'll add labels next time to remind me. It will be in 1.5.1. There will be no further 1.4.X release. |
|
@brwe I see, 1.5.1 then, that's fine. Thanks! |
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This adds the Explanation to the explain score again. It is needed because the explanation of script functions will otherwise not contain an explanation of _score if boost mode is set to replace. closes elastic#9826
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Explanation to the explainScore() again. It is needed
because the explanation of script functions will otherwise not contain
an explanation of _score if boost mode is set to replace.