Function score: Apply min_score to sub query score if no function provided
#10326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 20b9ee9.
…ovided For optimization pruposes a function score query with an empty function will just result in the original sub query. However, sometimes one might want to use function_score query to actually filter out docs within for example bool clauses by using the min_score functionallity. Therefore the sub query should only be used without wrapping inside a function_score query if min_score was also not set. closes elastic#10253
| && this.maxBoost == other.maxBoost; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return subQuery.hashCode() + 31 * function.hashCode() ^ Float.floatToIntBits(getBoost()); | ||
| return subQuery.hashCode() + 31 * (function == null ? 0 : function.hashCode()) ^ Float.floatToIntBits(getBoost()); |
There was a problem hiding this comment.
Note that you can use Objects.hashCode(function) directly which will make sure to return 0 if the value is null.
|
LGTM |
brwe
added a commit
that referenced
this pull request
Mar 31, 2015
…ovided For optimization pruposes a function score query with an empty function will just result in the original sub query. However, sometimes one might want to use function_score query to actually filter out docs within for example bool clauses by using the min_score functionallity. Therefore the sub query should only be used without wrapping inside a function_score query if min_score was also not set. closes #10253 closes #10326
brwe
added a commit
that referenced
this pull request
Mar 31, 2015
…ovided For optimization pruposes a function score query with an empty function will just result in the original sub query. However, sometimes one might want to use function_score query to actually filter out docs within for example bool clauses by using the min_score functionallity. Therefore the sub query should only be used without wrapping inside a function_score query if min_score was also not set. closes #10253 closes #10326
clintongormley
changed the title
clintongormley
changed the title
min_score to sub query score if no function provided
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ovided For optimization pruposes a function score query with an empty function will just result in the original sub query. However, sometimes one might want to use function_score query to actually filter out docs within for example bool clauses by using the min_score functionallity. Therefore the sub query should only be used without wrapping inside a function_score query if min_score was also not set. closes elastic#10253 closes elastic#10326
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For optimization purposes a function score query with an empty function
will just result in the original sub query. However, sometimes one might
want to use function_score query to actually filter out docs within for example
bool clauses by using the min_score functionality.
Therefore the sub query should only be used without wrapping inside
a function_score query if min_score was also not set.
closes #10253