Add enabled flag for _field_names to replace disabling through index:no
#9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
force-pushed
the
fix/field-names-enabled
branch
from
f5ab1f3
to
837211d
Compare
|
LGTM |
…ugh index=no Almost all of our meta fields that allow enabling/disabling have an `enabled` setting. However, _field_names is enabled by default, and disabling requires setting `index=no`. This change adds a flag similar to that with other meta fields. closes elastic#9893
rjernst
force-pushed
the
fix/field-names-enabled
branch
from
837211d
to
4c720f5
Compare
rjernst
added
v2.0.0-beta1
v1.5.0
:Search/Mapping
rjernst
force-pushed
the
fix/field-names-enabled
branch
from
4c720f5
to
257cdcd
Compare
rjernst
added a commit
that referenced
this pull request
Feb 26, 2015
…ugh index=no Almost all of our meta fields that allow enabling/disabling have an `enabled` setting. However, _field_names is enabled by default, and disabling requires setting `index=no`. This change adds a flag similar to that with other meta fields. closes #9893 Conflicts: src/main/java/org/elasticsearch/index/mapper/internal/FieldNamesFieldMapper.java
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 25, 2015
In elastic#9893, an enabled flag was added for _field_names. However, backcompat for indexes created before 1.3.0 (when _field_names was added) was lost. This change corrects the mapper to always be disabled when used with older indexes that cannot have _field_names. closes elastic#10268
clintongormley
changed the title
index=noenabled flag for _field_names to replace disabling through index:no
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
In elastic#9893, an enabled flag was added for _field_names. However, backcompat for indexes created before 1.3.0 (when _field_names was added) was lost. This change corrects the mapper to always be disabled when used with older indexes that cannot have _field_names. closes elastic#10268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of our meta fields that allow enabling/disabling have an
enabledsetting. However, _field_names is enabled by default, and disabling
requires setting
index=no. This change adds a flag similar to thatwith other meta fields.