Unneccesary mapping refreshes caused by unordered fielddata settings #10370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fielddata settings
| @@ -750,10 +750,13 @@ protected void doXContentBody(XContentBuilder builder, boolean includeDefaults, | |||
| builder.field("similarity", SimilarityLookupService.DEFAULT_SIMILARITY); | |||
| } | |||
|
|
|||
| TreeMap<String, Object> orderedFielddataSettings = new TreeMap<String, Object>(); | |||
There was a problem hiding this comment.
we miss an import here, I believe
There was a problem hiding this comment.
also the TreeMap<String,Object>() can be simplified to:
TreeMap<String, Object> orderedFielddataSettings = new TreeMap<>();
|
Thx @EikeDehling . I think the fix is good. I made some comments on improving the test. Once that's done I can pull this in. |
|
@bleskes Thanks for the tips, i adjusted as you suggested. |
|
looks good. I'll pull it in. Thx! |
bleskes
pushed a commit
that referenced
this pull request
Apr 2, 2015
bleskes
pushed a commit
that referenced
this pull request
Apr 2, 2015
|
Merged. Thx Eike. |
clintongormley
added
:Search/Mapping
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10318
Happy to hear feedback, e.g. suggestions to make the test simpler.