Fixes issue with calculation position from index with BR tags in ie #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +122,9 @@ class Selection | |||
| return this._decodePosition(leaf.node, offset) | |||
|
|
|||
| _positionToIndex: (node, offset) -> | |||
| if dom.isIE(10) and node.innerHTML == '<br>' and offset == 1 | |||
There was a problem hiding this comment.
Can you collapse this into one line:
offset = 0 if dom.isIE(10) and node.tagName == 'BR' and offset == 1
|
@jhchen Done :) |
|
@jhchen Need any help on extracting the modules out of the main codebase? I think quill should be split up into a core (all the dom, selection, delta stuff) and then each module can be added manually through using the core. I am happy to help on that if you provide the general guidelines you want to take it. |
jhchen
added a commit
that referenced
this pull request
Mar 20, 2015
Fixes issue with calculation position from index with BR tags in ie
|
Great thanks! Yes Quill ideally should be broken up into more independent parts but it's still unclear where the lines should be drawn and the inventory of dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you focus on a line that only has a BR tag in it ie will set the start of the range always to 1 which is inconsistent with other browsers which return 0.