Multiple emails #755
Merged
Multiple emails #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new struct is created named EmailAddress that contains alternative email addresses for users. Also the email related methods; IsEmailUsed and GetUserByEmail are updated. DeleteUser deletes the extra email addresses and DeleteInactivateUsers also deletes inactive accounts. This could be factored out, but should do it for now.
All basics are implemented. Missing are the right (localized) strings and the page markup could have a look at by a frontend guy.
|
Incredible! Thanks, we'll review it ASAP. |
| // primary email address, but is not obligatory | ||
| type EmailAddress struct { | ||
| Id int64 | ||
| OwnerId int64 `xorm:"INDEX NOT NULL"` |
There was a problem hiding this comment.
Would it be better to just use Uid?
There was a problem hiding this comment.
Do you mean instead of OwnerId? I copied the style from a PublicKey struct to call it OwnerId, but Uid would do fine as well.
There was a problem hiding this comment.
Hmm, OwnerId is fine. I'm just thinking Uid is shorter...
|
Hi, thanks your PR again! I've made some comments. Not able to see UI yet, would check on that after this is merged. |
|
I'll try to check the comments today and make some improvements |
|
I fixed the issues you mentioned in 20b5c23 |
|
Thanks! Sorry for late, I just finished my final exam this week and prepare for going back to home. |
ethantkoenig
pushed a commit
to ethantkoenig/gogs
that referenced
this pull request
Jan 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing the option of adding multiple email addresses to a single user, so I tried to implement this. Please let me know how you like it! I am willing to fix it/change it as desired!