Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tick.count returns "undefined" if axis is categorical #935

Closed
aendra-rininsland opened this issue Jan 23, 2015 · 4 comments
Closed

tick.count returns "undefined" if axis is categorical #935

aendra-rininsland opened this issue Jan 23, 2015 · 4 comments
Labels
C-bug Category: This is a bug resolved maybe

Comments

@aendra-rininsland
Copy link
Member

Right now I think C3 tries to distribute the specified number of ticks across whichever axis tick.count is specified for. However, this isn't really joined up with the axis data, so it returns undefined. tick.values doesn't do anything with categorical axes AFAICT.

Plunker: http://plnkr.co/edit/ziuUfIYLdgnWmitXUbfg
screen shot 2015-01-23 at 18 25 23
@aendra-rininsland aendra-rininsland added the C-bug Category: This is a bug label Jan 23, 2015
@aendra-rininsland aendra-rininsland mentioned this issue Jan 23, 2015
Closed
@aendra-rininsland aendra-rininsland changed the title tick.count doesn't work if axis is categorical tick.count returns "undefined" if axis is categorical Jan 24, 2015
@aendra-rininsland
Copy link
Member Author

Worth noting that it just displayed the tick without a value in 0.3.0; printing "undefined" seems like a regression from that.

masayuki0812 added a commit that referenced this issue Jan 26, 2015
@masayuki0812
Fix undefined when axis.x.tick.count specified on category axis - #935
d3d4c5d
@masayuki0812
Copy link
Member

I fixed this to show empty string instead of undefined. I'll release in the next version 0.4.10 shortly. Thanks.

@aendra-rininsland
Copy link
Member Author

Yay! Thanks! 👍

@masayuki0812
Copy link
Member

0.4.10 has been released, so let me close. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug resolved maybe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aendra-rininsland @masayuki0812