Fix Function.prototype.bind polyfill by using Mozillas suggested script #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masayuki0812 Please review at your convenience. |
masayuki0812
added a commit
that referenced
this pull request
Mar 15, 2015
Fix Function.prototype.bind polyfill by using Mozillas suggested script
|
Looks nice. Thank you very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR fixes a bug with the
Function.prototype.bindpolyfill where arguments passed intobindweren't being included when the function was eventually executed. I've included three examples showing the expectation without a polyfill, what's currently happening in master, and how the polyfill should be implemented in order to emulate the baseline.No Polyfill (baseline)
C3 master (broken)
Solution
C3 matthelm:phantom-polyfill (fixed)
The code for the PR is copied from MDN's suggested polyfill here. I'm unsure how to best write tests for this code, and because the current polyfill didn't have tests I'm submitting this PR without any. That said, I'm happy to add them.