Adds Sass support #837
Adds Sass support #837
Conversation
aendra-rininsland
force-pushed
the
803_adding_compass
branch
from
f8bc0c7
to
99a3a65
Compare
|
+1 |
aendra-rininsland
added
the
C-feature-request
|
@masayuki0812 Any thought on whether this is desirable? Personally, I think it'd be really helpful for making everything more modular, and improving tooling (i.e., adding autoprefixer) will help long-term for ensuring things like browser cross compatibility (Vendor prefixes are used fairly arbitrarily in the existing CSS, it seems). If you plan to merge this, please let me know and I'll resolve the current conflicts ASAP. Thanks! |
|
@Aendrew Why not use Stylus instead? I'd rather have Stylus and carry on with Node.js/JavaScript than introduce Ruby to the mix. |
|
@jmnunezizu I've never used Stylus, but node-sass uses the C++ version of Compass — Ruby-free! If @masayuki0812 has me update this PR, I've switch to that (and grunt-sass) instead of the Ruby version. Quite agreed it would be nice not to add Ruby to the mix. |
|
@Aendrew I haven't used Sass extensively (happy stylus user myself) but I trust your judgement. |
|
@Aendrew Sorry for late response.. I think it's ok to merge this PR basically, so could you fix the conflict? Thank you. |
|
@masayuki0812 No worries! I've updated the PR to merge successfully, as well as changed it from |
|
Yeah, I actually find it extremely hard to manage the styles. Somehow, it interferes with my css styling I use for our site (bootstrap). I'm on less myself. But I suppose that it's easy to convert |
|
Looks very nice. Thanks! |
|
Woo! Thanks @masayuki0812! 👍 |
See #803. I've separated c3.css into its component parts and pulled all those into main.scss, which gets written to c3.css (and minified during the default
grunttask). I haven't optimised or organised the scss files any further than that.Might be worth considering optimising these into more readable SCSS, in addition to adding grunt-autoprefixer to automatically add vendor prefixes where necessary.