Adds c3_chart_internal_fn.isTabVisible to disable transitions on inactive tabs. Fixes #924. #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctive tabs. Fixes c3js#924.
aendra-rininsland
force-pushed
the
fixing_924
branch
from
f00e102
to
a4c5b7a
Compare
masayuki0812
added a commit
that referenced
this pull request
Jan 26, 2015
Adds c3_chart_internal_fn.isTabVisible to disable transitions on inactive tabs. Fixes #924.
|
Looks nice. Thanks! |
|
Yay! Thanks! 👍 |
|
I have serious doubts if this is a proper fix for the issue, after all it should not leak and GC correctly regardless of visibility? |
|
@ergo The GC and memory leak issue is a separate one; I totally agree this is not the fix for that. This is merely to resolve the issue with requestAnimationFrame not firing in inactive tabs, resulting in the chart not rendering if |
This was referenced Feb 27, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new function,
c3_chart_internal_fn.isTabVisible, which uses the Page Visibility API to return whether the page is inactive or not. I've then called itc3_chart_internal_fn.redraw()on line 614 ofsrc/core.js, which short-circuits the conditional and renders the chart without usingd3.transition(which uses therequestAnimationFrameAPI, which doesn't work on inactive tabs) if the chart's browser tab is inactive.See #924.