Allow to recv and send file descriptors when using EpollDomainSocketChan... #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trustin please review |
|
|
||
| descriptorMessage.msg_control = control; | ||
| descriptorMessage.msg_controllen = sizeof(control); | ||
| struct cmsghdr *cmsg = CMSG_FIRSTHDR(&descriptorMessage); |
There was a problem hiding this comment.
Gentle reminder on consistent asterisk position :-)
|
First pass done. Please ping me for another pass. |
normanmaurer
force-pushed
the
domain_socket_2
branch
from
c9963a3
to
8b5f6a0
Compare
|
@trustin ping :) |
normanmaurer
force-pushed
the
domain_socket_1
branch
from
217e176
to
5f2be6a
Compare
normanmaurer
force-pushed
the
domain_socket_2
branch
from
8b5f6a0
to
099b333
Compare
…hannel. Motiviation: When using domain sockets on linux it is supported to recv and send file descriptors. This can be used to pass around for example sockets. Modifications: - Add support for recv and send file descriptors when using EpollDomainSocketChannel. - Allow to obtain the file descriptor for an Epoll*Channel so it can be send via domain sockets. Result: recv and send of file descriptors is supported now.
normanmaurer
force-pushed
the
domain_socket_2
branch
from
099b333
to
e77d683
Compare
| } | ||
|
|
||
| if (res < 0) { | ||
| return -err; |
There was a problem hiding this comment.
Perhaps we could merge the two ifs:
if (res <= 0) {
return -err;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nel.
Motiviation:
When using domain sockets on linux it is supported to recv and send file descriptors. This can be used to pass around for example sockets.
Modifications:
Result:
recv and send of file descriptors is supported now.