Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

Add auto-update support #232

Closed
mwbrooks opened this issue Dec 3, 2014 · 3 comments
Closed

Add auto-update support #232

mwbrooks opened this issue Dec 3, 2014 · 3 comments
Assignees
@hermwong
Labels
enhancement
Milestone
0.1.5 Beta

Comments

@mwbrooks
Copy link
Collaborator

mwbrooks commented Dec 3, 2014

We should consider adding auto-update support. When a newer version of the application is available, we can download it, install it, and reopen the application automatically. This is pretty standard in most modern desktop apps.

By the looks of it, node-webkit defers this responsibility to: https://github.com/edjafarov/node-webkit-updater

It looks like it's an active project that's well designed and easy to use. I'm not sure how well it works though.
@hermwong hermwong added this to the Post 1.0 Release enhancements milestone Dec 4, 2014
@hermwong hermwong self-assigned this Dec 4, 2014
@hermwong hermwong modified the milestones: Post 1.0 Release enhancements, 0.1.2 Beta Dec 12, 2014
hermwong added a commit that referenced this issue Jan 7, 2015
@hermwong
[#232] updated package.json to include manifestUrl and packages prope…
ce92b86 
…rties
hermwong added a commit that referenced this issue Jan 7, 2015
@hermwong
[#232] instantiate the node-webkit-updater
023b38c
hermwong added a commit that referenced this issue Jan 7, 2015
@hermwong
[#232] stubbed in the auto-update code
31d50b1
hermwong added a commit that referenced this issue Jan 8, 2015
@hermwong
[#232] updated version to test the auto-updater
c13d23b
hermwong added a commit that referenced this issue Jan 8, 2015
@hermwong
[#232] updated version to test the auto-updater
131beb3
hermwong added a commit that referenced this issue Jan 8, 2015
@hermwong
[#232] updated the manifestUrl to the correct url
43c0d16
hermwong added a commit that referenced this issue Jan 9, 2015
@hermwong
[#232] updated the manifestUrl to point /package.json instead of www/…
0412148 
…package.json
hermwong added a commit that referenced this issue Jan 9, 2015
@hermwong
[#232] minor code cleanup and updated comments for auto-updater
3dad1bb
@hermwong hermwong modified the milestones: 0.1.3 Beta, 0.1.2 Beta Feb 23, 2015
hermwong added a commit that referenced this issue Feb 26, 2015
@hermwong
[#232] updated to version to 0.1.3 for auto update testing
c408772
hermwong added a commit that referenced this issue Feb 26, 2015
@hermwong
[#232] modified update button on the update app dialog to download th…
67bb77d 
…e newest version of pg-desktop when a new version is available
hermwong added a commit that referenced this issue Feb 27, 2015
@hermwong
[#232] added restart dialog to inform user that the update is ready t…
917a5a6 
…o install
@hermwong hermwong modified the milestones: 0.1.3 Beta, 0.1.4 Beta Mar 12, 2015
@hermwong hermwong modified the milestones: 0.1.4 Beta, 0.1.5 Beta Apr 2, 2015
@hollyschinsky
Copy link
Collaborator

Getting some issues with auto-update when going from 0.1.3 to the latest version (0.1.4). Tried on two machines, with the following results:

When I run this on a laptop running Yosemite (10.10.2), the green Update button downloads the app to a temp folder (to Macintosh HD ▸ private ▸ var ▸ folders ▸ _x ▸ s6wsj5sd659d0fp45dbnyd_m0000gn ▸ T ▸ PhoneGap-Desktop-Beta-0.1.4-mac) but doesn't complete the installation when I click Restart. It appears to try to open and run it but stays blank then closes on it's own.

When I tried on another laptop running OS X 10.9.2 it downloads the file (to Macintosh HD ▸ private ▸ var ▸ folders ▸ _x ▸ s6wsj5sd659d0fp45dbnyd_m0000gn ▸ T ▸ PhoneGap-Desktop-Beta-0.1.4-mac) and opens it when I click Restart, but it doesn't move it to the Applications folder or overwrite the old version so I would have to go find it again to open it otherwise I still get the old one.

@hermwong
Copy link
Collaborator

hermwong commented Apr 7, 2015

It looks like the update is being properly downloaded and unzipped in the temp folder, but when the restart happens the PG-Desktop opens with a blank screen and the updated version doesn't seem to get copied over to the Applications folder (tested on Yosemite OSX 10.10.2).

When the restart is triggered from the Restart button it tries to run the updated version of PG-Desktop from the temp folder. If I navigate to the temp folder in Finder and click on the downloaded update the PG-Desktop does load properly. I still need to determine reason for the blank screen when the restart is triggered from the PG-Desktop.

Basically there are 2 issues that are causing the auto-update to fail:

  1. Restart doesn't work when triggered from PG-Desktop
  2. Updated PG-Desktop isn't being copied over to the Applications folder.

hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Apr 8, 2015
@hermwong
[phonegap#232] updated to version to 0.1.3 for auto update testing
ebf7d00
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Apr 8, 2015
@hermwong
[phonegap#232] modified update button on the update app dialog to dow…
9cdfce1 
…nload the newest version of pg-desktop when a new version is available
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Apr 8, 2015
@hermwong
[phonegap#232] added restart dialog to inform user that the update is…
cf029af 
… ready to install
@hermwong
Copy link
Collaborator

hermwong commented Apr 9, 2015

Discovered that the update will fail if the user goes through the auto-update workflow which fails the restart and then attempts to auto-update again when they manually restart.

It seems that there is an issue / conflict when attempting to re-download the update when the user attempts the second auto-update because the zip already exists in the temp folder.

hermwong added a commit that referenced this issue Apr 15, 2015
@hermwong
[#232] make sure the copyPath & execPath are using the correct values…
0e0a2f7 
… for auto-update on OSX
hermwong added a commit that referenced this issue Apr 23, 2015
@hermwong
[#232] fixed auto-updater for OSX, modified the update prompt to poin…
f9f2e62 
…t users to the PG-Desktop release page
hermwong added a commit that referenced this issue Apr 27, 2015
@hermwong
[#232] make sure the copyPath & execPath are using the correct values…
c292d6f 
… for auto-update on OSX
hermwong added a commit that referenced this issue Apr 27, 2015
@hermwong
[#232] fixed auto-updater for OSX, modified the update prompt to poin…
95b6415 
…t users to the PG-Desktop release page
hermwong added a commit that referenced this issue Oct 26, 2016
@hermwong
[#232] updated to version to 0.1.3 for auto update testing
eaea6ab
hermwong added a commit that referenced this issue Oct 26, 2016
@hermwong
[#232] modified update button on the update app dialog to download th…
00070f3 
…e newest version of pg-desktop when a new version is available
hermwong added a commit that referenced this issue Oct 26, 2016
@hermwong
[#232] added restart dialog to inform user that the update is ready t…
bd9114c 
…o install
hermwong added a commit that referenced this issue Oct 26, 2016
@hermwong
[#232] make sure the copyPath & execPath are using the correct values…
b9c4d35 
… for auto-update on OSX
hermwong added a commit that referenced this issue Oct 26, 2016
@hermwong
[#232] fixed auto-updater for OSX, modified the update prompt to poin…
9e002bc 
…t users to the PG-Desktop release page
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] updated to version to 0.1.3 for auto update testing
6ecbbdf
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] modified update button on the update app dialog to dow…
168f110 
…nload the newest version of pg-desktop when a new version is available
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] added restart dialog to inform user that the update is…
ce2c4dd 
… ready to install
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] updated to version to 0.1.3 for auto update testing
f72c0c9 
Former-commit-id: 6ecbbdf
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] modified update button on the update app dialog to dow…
189013b 
…nload the newest version of pg-desktop when a new version is available

Former-commit-id: 168f110
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] added restart dialog to inform user that the update is…
57b9bb6 
… ready to install

Former-commit-id: ce2c4dd
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] updated to version to 0.1.3 for auto update testing
21e9193
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] updated to version to 0.1.3 for auto update testing
afeb3bb 
Former-commit-id: 6ecbbdf
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] modified update button on the update app dialog to dow…
cad0f13 
…nload the newest version of pg-desktop when a new version is available
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] modified update button on the update app dialog to dow…
f472997 
…nload the newest version of pg-desktop when a new version is available

Former-commit-id: 168f110
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] added restart dialog to inform user that the update is…
5d1070b 
… ready to install
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] added restart dialog to inform user that the update is…
e8c60fc 
… ready to install

Former-commit-id: ce2c4dd
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] updated to version to 0.1.3 for auto update testing
ad7ff48 
Former-commit-id: 21e9193
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] modified update button on the update app dialog to dow…
02e0117 
…nload the newest version of pg-desktop when a new version is available

Former-commit-id: cad0f13
hermwong added a commit to hermwong/phonegap-app-desktop that referenced this issue Oct 27, 2016
@hermwong
[phonegap#232] added restart dialog to inform user that the update is…
1f72a49 
… ready to install

Former-commit-id: 5d1070b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hermwong hermwong

Labels
enhancement
Milestone
0.1.5 Beta
Development

No branches or pull requests
3 participants
@mwbrooks @hermwong @hollyschinsky