Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rethinkdb.stats.written_docs_total is broken #3713

Closed
timmaxw opened this issue Feb 3, 2015 · 2 comments
Closed

rethinkdb.stats.written_docs_total is broken #3713

timmaxw opened this issue Feb 3, 2015 · 2 comments
Assignees
@Tryneus
Labels
tp:bug
Milestone
1.16.1

Comments

@timmaxw
Copy link
Member

timmaxw commented Feb 3, 2015

The written_docs_total field in rethinkdb.stats incorrectly displays 0 in the stat dumps posted in #3712. I think this is because of a perfmon name mismatch; btree/slice.hpp publishes a perfmon called total_keys_set, but clustering/administration/stats/request.cc looks for a perfmon called total_keys_written.
@timmaxw timmaxw added the tp:bug label Feb 3, 2015
@danielmewes danielmewes added this to the 1.16.x milestone Feb 3, 2015
@Tryneus
Copy link
Member

Tryneus commented Feb 3, 2015

Fix up in review 2561.

@Tryneus
Copy link
Member

Tryneus commented Feb 4, 2015

The fix has been approved and merged to next in commits ff8c26b and 05d9ea5, and cherry-picked into `v1.16.x in commits 28d4870 and cdde59f. Will be in release 1.16.1.

@Tryneus Tryneus closed this as completed Feb 4, 2015
@AtnNn AtnNn modified the milestones: 1.16.x, 1.16.1 Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tryneus Tryneus

Labels
tp:bug
Projects
None yet
Milestone
1.16.1
Development

No branches or pull requests
4 participants
@timmaxw @danielmewes @Tryneus @AtnNn