Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitmapPool hit rate decreased in Glide 3.5 #335

Closed
sjudd opened this issue Feb 8, 2015 · 0 comments
Closed

BitmapPool hit rate decreased in Glide 3.5 #335

sjudd opened this issue Feb 8, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@sjudd
Copy link
Collaborator

sjudd commented Feb 8, 2015

To work around #301, we banned Bitmaps with configs other than ARGB_8888 from being placed into the BitmapPool and defaulted to always requesting ARGB_8888 Bitmaps.

Unfortunately the framework doesn't always obey inPreferredConfig. GIFs in particular almost always produce Bitmaps with null (hidden) configs.

Since those Bitmaps are banned from the pool, apps displaying a mix of single frame GIFs and other content will end up with a net drain on the BitmapPool, causing jank.

From some limited testing it appears safe to re-use ARGB_8888 Bitmaps to decode single frame GIFs, and to re-use Bitmaps with null configs to decode most image types with inPreferredConfig == ARGB_8888.

@sjudd sjudd added the bug label Feb 8, 2015
@sjudd sjudd self-assigned this Feb 8, 2015
@sjudd sjudd added this to the 3.5.2 milestone Feb 8, 2015
@sjudd sjudd closed this as completed in 431ccaf Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant