Feature list preloader support multiple target sizes #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that |
|
@TWiStErRob which |
|
|
| @@ -102,16 +100,36 @@ | |||
| */ | |||
| @Deprecated | |||
| public ListPreloader(int maxPreload) { | |||
| this(null, null, maxPreload); | |||
| this.preloadModelProvider = new PreloadModelProvider<T>() { | |||
There was a problem hiding this comment.
Good call, this is definitely cleaner, thanks!
… to preloadAdapterPosition(List<T> items, int position, boolean isIncreasing)
sjudd
added a commit
that referenced
this pull request
Nov 21, 2014
…rt-multiple-sizes Feature list preloader support multiple target sizes
DavidWiesner
deleted the
feature-ListPreloader-support-multiple-sizes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide different target sizes in the
ListPreloader, i had toPreloadSizeProvider<T>togetPreloadSize(T item, int adapterPostion, int itemPosition)PreloadModelProvideto request the preload items one by one. This is needed to provide theitemPositiontoPreloadSizeProvider.getPreloadSize()method.In addition i added some test cases for the new functionality and adapt the old tests to the one by one approach.
I also change the deprecated
ListPreloader(int maxPreload)constructor, to remove some null checks and make it easier to later remove the deprecated constructor and the methods.regard,
David