Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y Axis Mishandeling Data Labels #799

Closed
philipcdavis opened this issue Dec 3, 2014 · 5 comments
Closed

Y Axis Mishandeling Data Labels #799

philipcdavis opened this issue Dec 3, 2014 · 5 comments
Labels
C-bug Category: This is a bug resolved maybe

Comments

@philipcdavis
Copy link

When you have data labels, and padding is not specified you get some strange behavior illustrated in this fiddle.

http://jsfiddle.net/atfkc53d/

I suspect it has something to do with a default padding amount.
Maybe there needs to be a dynamic way to introduce label padding?
This problem seems to have been introduced between version 0.3 and 0.4.

@aendra-rininsland
Copy link
Member

@philipcdavis Confirming bug. It's weird, it doesn't matter what value you put for the Y-axis padding, the problem is solved. Working version at http://jsfiddle.net/xouqm42n/.

@aendra-rininsland aendra-rininsland added the C-bug Category: This is a bug label Dec 4, 2014
@philipcdavis
Copy link
Author

@Aendrew The fiddle you posted is working with one exception. The largest bar chart label is still getting cut off. Updating the padding fixes it, but not in a flexible way.

In my case it would be much easier if the top padding was based off pixels, not relative to the Y Axis scale. For instance, padding{top: 10} should be 10 pixels below the top of the scale, not 10 points on the scale. That way your bar chart would be flexible enough to handle any data set (Whether the scale is 0-1, or 0-100). Does this make sense?

@masayuki0812
Copy link
Member

@philipcdavis Thanks for your reporting. I think this issue has been fixed and I modified to assume axis.y.padding is pixels as default. I'll release them in the next version v0.4.8.

@philipcdavis
Copy link
Author

This is working for me now. Thanks for the fix!

@masayuki0812
Copy link
Member

Thanks. v0.4.8 has been released, so please let me close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug resolved maybe
Projects
None yet
Development

No branches or pull requests

3 participants