Test comment

@unknwon Does anyone work on this issue?

We're discussing this in the dev group.

+1
Eagerly waiting for this feature

+1
It's important feature

⭐

Super excited for this!

+1

+1

+1

• 1

👍

Update: master branch just pushed fork feature, PR is on the way!

👍

+1 This (pull requests) would help adoption as well, since it's a key feature when you start dealing with a team of more than just a couple of people.

@bradleypeabody you're absolutely right!

+1 for pull requests

I have to choose between gitlab and gogs for managing repos at a company, if pull requests are going to be added soon gogs will be the winner.

@hugochinchilla we're working on PR right now, should be released in near future. But GitLab obviously has more features than Gogs at current stage, make the best choice is important, your option.

+1 for Pull Request, so could we hope to replace Gitorious currently used in LinkedIn. Gitorious Merge Request feature sucks.

+1 for Pull Request
Needed to migrate private repos to gogs

+1 for Pull Requests

Awesome job btw!

+1 for Pull Requests! Really looking forward to trying this once this functionality is added!

+1 for pull requests. We're using organisations / teams in the interim.

Thank you for following up! @bastiao @xaionaro

@ALL: It's in very early stage, so... be nice... 👀

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

Yes, it will be added soon. I'm working on it.

I'm updating my own installation and will test it properly. I will happy to return feedback too.

PS and offtopic: you should talk with people that fork gogs. It is not good to community to have disperse forks around. They was working on PR/forks too.

# github.com/gogits/gogs/routers/api/v1
routers/api/v1/repo.go:105: opt.Gitignore undefined (type gogs.CreateRepoOption has no field or method Gitignore)
routers/api/v1/repo_hooks.go:29: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/repo_hooks.go:105: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/user.go:21: unknown gogs.User field 'Id' in struct literal

any idea why?

@bastiao

go get -u github.com/gogits/go-gogs-client

and then rebuild

@unknwon great, thanks!

When opening a pull request the original repo gets a new open issue that is closed after merging.
This works for the issue view but in the overview for the original repo there is still one issue too much shown to be open. I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

e.g.:
When you had 10 open issues before the PR, you have 11 open after the PR, 10 open after merge but the overview still shows 11

(This was tested on try.gogs.io)

BTW: Thanks a lot for this feature.

@unknwon the PR does not work inside the same repository. Only in forks?
I mean, it is useful in different branches of same repository.

@bastiao right now, yes, only between forks(in same repo in the design though)

I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

@mexthemax good catch! Forgot that...

A friend of mine juste told me "Too bad it doesn't handle PRs". Went here. Saw the comment one hour ago saying it's now in test. Epic timing ! 💃

I am the friend in question. I've wanted to switch to Gogs for so long but I needed PR support. I'm so happy, thanks guys! :D

@ALenfant hah, 😝

Note it's still early stage and may not as perfect as you expected. But I'm here to fix problems. 👀

A bug here: https://try.gogs.io/swordwinter/prtest/pulls there is two pull requests, one open and one closed. But when you click on open PR, it will show the close one. It seems both of them got same id

Thanks @zarezadeh ! I've pushed fix to try.gogs.io , and have fixed the index for your PR on the server :)

Wow, that was fast, thanks.

This looks great! Waiting for this to get in to master.

If you can allow support of pull requests in the same project, between branches, it will be great!

OK, close right now.

Will open new issues for other specific needs.

Important update

I've pushed code to develop branch and https://try.gogs.io that check if pull request has conflict with upstream every time fork repository or upstream repository is pushed, so conflict will be detected correspondingly right now.

Leave feedback here so I can help with further problems you may encounter! 🍻