Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17 Tags make cloning freeze #572

Closed
killfill opened this issue Oct 15, 2014 · 7 comments
Closed

17 Tags make cloning freeze #572

killfill opened this issue Oct 15, 2014 · 7 comments
Labels
💊 bug Something isn't working

Comments

@killfill
Copy link

Hi!

Im migrating some repos to gogs, and noticed something strange.

When a repo has 17 or more tags, then when trying to 'git clone' on a client, the process stops at:

   $ git clone http://myrepo/me/reponame
   Cloning into 'reponame'...

What i did before cloning, was create an empty repo, upload a dummy file, and then:

   for i in `seq 17`; do git tag $i; git push --tags; done

Im using version 0.5.5.1013 Beta, compiled from source commit 4a8a70d, using postgresql DB.

This only happend with HTTP (which i need to use..), when cloning through SSH works fine.

Can anyone replicate this?

Thanks!!
@killfill
Copy link
Author

Btw, i see no error on the logs, just this:

[Macaron] Started GET /me/reponame/info/refs for 172.16.11.44
[Macaron] Completed /me/reponame/info/refs 200 OK in 44.661287ms
[Macaron] Started POST /me/reponame/git-upload-pack for 172.16.11.44
[Macaron] Completed /me/reponame/git-upload-pack 200 OK in 44.06505ms

@unknwon unknwon added the 💊 bug Something isn't working label Oct 15, 2014
@unknwon
Copy link
Member

unknwon commented Oct 15, 2014

Thanks your feedback, bug confirmed!

@unknwon
Copy link
Member

unknwon commented Oct 15, 2014

BTW, logs are in log/http.log

@unknwon
Copy link
Member

unknwon commented Oct 15, 2014

OK, I've found the issue, Gogs didn't handle GZIP through HTTP/HTTPS when the object data size of Git is large(normal case, less then 1KB, but when tags number is large, Git will compress them with GZIP).

@unknwon
Copy link
Member

unknwon commented Oct 15, 2014

I've pushed fix on master, please help test, thanks! I've tested with 21 tags.

@killfill
Copy link
Author

Seems to be working fine now
Thanks!!

@unknwon
Copy link
Member

unknwon commented Oct 15, 2014

No problem!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@killfill @unknwon