-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German localisation: Avg. generation time shown in full seconds in row evolution graph #5330
Comments
Attachment: |
Thanks for the report! I could reproduce also. the problem comes from the fact that in German numbers are: 0,8s and this results in the bug (in english they are displayed as 0.8s) |
That one already works for me on the current demo. |
Might be fixed in #6435. Please note even if it seems to be fixed on the current demo it could be still broken depending on which locale Piwik uses to track and archive data. I just tried to reproduce on demo and it still shows the data in full seconds instead of floats when using German language... I'll have a quick look |
…s used or another locale that uses a comma instead of dot to separate decimal
I have a fix for this that I will merge as soon as the tests pass. It will now output actual float values but it will use a dot instead of a comma to separate the decimal part which is wrong. I cannot really fix this currently as we need a lib to format numbers in JavaScript depending on the users language/country etc. We should fix this in #6620 and pick a lib there. It shows once more how important this issue is. I cannot format the number in PHP (I tried it) as it will be converted to float in JavaScript again: |
PIWIK 2.3.0, german localisation:
In the row evolution graphs the avg. generation time is displayed rounded to full seconds instead of rounded to two decimal places.
In the english language version this behaviour doesn't occur.
Keywords: row evolution view german localisation
The text was updated successfully, but these errors were encountered: