Removed group check before running any PHP tests. #6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check does not really makes sense as a group was never needed for a test to be executed on Travis. The testsuites that always have been used on Travis automatically execute all tests within the PHPUnit/Unit Integration and System folder. A group was never needed. Maybe some developers used groups to execute tests but then always only a part of the tests was executed as a test does not necessarily has the "correct" group. Removing this check is also important for plugin developers who write tests for their plugin as we cannot expect that they set a group as it is usually not needed in any other project. If plugin developers do not set a group and we run our automated tests no test would be executed because of this unneeded check.
|
Does it mean |
|
Exactly. It is nice to have but not really mandatory and not even so useful. At some point we could maybe even add groups "dynamically" as we now core tests are always in |
mattab
pushed a commit
that referenced
this pull request
Nov 10, 2014
Removed group check before running any PHP tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check does not really makes sense as a group was never needed
for a test to be executed on Travis. The testsuites that always have been
used on Travis automatically execute all tests within the PHPUnit/Unit
Integration and System folder. A group was never needed. Maybe some
developers used groups to execute tests but then always only a part of
the tests was executed as a test does not necessarily has the "correct"
group. Removing this check is also important for plugin developers who
write tests for their plugin as we cannot expect that they set a group
as it is usually not needed in any other project. If plugin developers
do not set a group and we run our automated tests no test
would be executed because of this unneeded check.