Created attachment 32104 [details] Code patch
Date: Mon Oct 13 21:02:22 2014 New Revision: 1631549 URL: http://svn.apache.org/r1631549 Log: Bug 57081 - Updating checkstyle to only check for tabs in java files (and not images!) Bugzilla Id: 57081 Modified: jmeter/trunk/checkstyle.xml jmeter/trunk/xdocs/changes.xml
Tabs are also deprecated in other text files such as xml, .txt etc.
Created attachment 32112 [details] Update to include more file formats
(In reply to Graham from comment #3) > Created attachment 32112 [details] > Update to include more file formats This is better, but the problem with the inclusion method is that new text file types will not be caught. Also there are several text file types that have been omitted (e.g. .properties, .rdf, README) I think it would be better to exclude binary types. There are probably fewer of those, and any omissions will be obvious as checkstyle will complain. Whereas omitted inclusions won't provide any indication.
Unfortunately checkstyle doesn't appear to allow exclusions only inclusions (it might be possible using an external 'suppressions' config file but that seems a little much). I'd prefer not to have false positives but potentially miss tabs in other obscure text files. Are tabs so evil in these other documents? On a slightly separate note, do people use this checkstyle config? It does seem to have a lot of things commented out and not be very big, could we perhaps use it more and include more things? FYI here is a list of all the file extensions JM currently has: all bat bsh bshrc cgi cmd conf css csv dtd fb fdl gif htm html idx jar java jmx jpg jsp jtl license MF notice odt pack parameters pdf png pom properties providers rdf readme sample set sh svg sxi sxw tsv txt vsl xcf xml xsd xsl
(In reply to Graham Russell from comment #5) > Unfortunately checkstyle doesn't appear to allow exclusions only inclusions > (it might be possible using an external 'suppressions' config file but that > seems a little much). http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#excludes > I'd prefer not to have false positives but potentially miss tabs in other > obscure text files. Are tabs so evil in these other documents? False positives can easily be fixed. > On a slightly separate note, do people use this checkstyle config? It does > seem to have a lot of things commented out and not be very big, could we > perhaps use it more and include more things? That is a subject for the developer list.
Date: Sat Oct 18 12:53:34 2014 New Revision: 1632783 URL: http://svn.apache.org/r1632783 Log: Bug 57081 - Updating checkstyle to only check for tabs in java, xml, xsd, xls, dtd, htm, html and txt files (not images!) Bugzilla Id: 57081 Modified: jmeter/trunk/checkstyle.xml jmeter/trunk/xdocs/changes.xml
Date: Sat Oct 18 13:49:29 2014 New Revision: 1632791 URL: http://svn.apache.org/r1632791 Log: Bug 57081 - Updating checkstyle to only check for tabs in java, xml, xsd, xls, dtd, htm, html and txt files (not images!) Avoid xls Bugzilla Id: 57081 Modified: jmeter/trunk/checkstyle.xml jmeter/trunk/xdocs/changes.xml
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3452