Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing markdown style #491

Closed
littlemo opened this issue Sep 20, 2014 · 10 comments
Closed

Missing markdown style #491

littlemo opened this issue Sep 20, 2014 · 10 comments
Labels
💻 ui You ruined my eyes!

Comments

@littlemo
Copy link

Hello, I use the gogs-0.5.2.0917 Beta
And find that the markdown grammar inline code, can't be display correctly
The display at 0.4.5.0704 Alpha:
old

And the display at 0.5.2.0917 Beta:
new

Source code is:

此产品`已停产`

It is not easy to distinguish, although there are different.
@unknwon
Copy link
Member

unknwon commented Sep 20, 2014

What exactly function you found this bug?

@fanningert
Copy link
Contributor

I think he mark the chinese text with the inline code markdown syntax.

@unknwon
Copy link
Member

unknwon commented Sep 20, 2014

@fanningert He didn't describe specific place to locate bug.

@littlemo
Copy link
Author

Hi, I have made a careful analysis of this, and find it doesn't matter with chinese.
It will happen when the inline code in a Lists(Unordered/Ordered), but the display is normal at 0.4.5.0704 Alpha

Normal:

The product has been `discontinued`!

The product has been discontinued!

Error:

1. The product has been `discontinued`!
or
* The product has been `discontinued`!
  1. The product has been discontinued!

or

  • The product has been discontinued!

The display is normal here, But error at 0.5.2

@unknwon
Copy link
Member

unknwon commented Sep 21, 2014

https://try.gogs.io/Unknown/gogs/issues/new I tested here and doesn't see the problem you describe, I still have no idea which functionality you're using? URL?

@tobyzxj
Copy link
Contributor

tobyzxj commented Sep 22, 2014

@unknwon You should be look at README.md from https://try.gogs.io/Unknown/gogs. It doesn't look the same.

@littlemo
Copy link
Author

oh...@unknwon it's my fault, the statement is not clear.
the bug occurs in Home Page

I create a repo at try.gogs.io

Thinks for @tobyzxj

Like this:

right

bug

@unknwon
Copy link
Member

unknwon commented Sep 22, 2014

@littlemo no worries, I see the problem now, it's like missing markdown style

@unknwon unknwon added the 💻 ui You ruined my eyes! label Sep 22, 2014
@unknwon unknwon changed the title the markdown file display error Missing markdown style Sep 22, 2014
unknwon added a commit that referenced this issue Sep 22, 2014
@unknwon
Fix #491
196efec
@unknwon
Copy link
Member

unknwon commented Sep 22, 2014

snip20140922_1

Just looks like GitHub right now, hope you like it. LOL

@unknwon unknwon closed this as completed Sep 22, 2014
@littlemo
Copy link
Author

Nice! (●′ω`●)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 ui You ruined my eyes!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fanningert @unknwon @tobyzxj @littlemo