Hi there, I've pushed a commit to fix the issue 1.

For issue 2, the reason not user user name in the link is because hard to match, but e-mail address is more likely to match, and its unique.

To encode the e-mail, I'm thinking about use base64 or some other encryption algorithms.

base64 is reversible (it can be decoded easily on the backed back into an email address), md5, although a weak hashing algorithm, is already used for gravatars and is not (at least not easily) reversible.

If base64 was used, no extra column would need to be added to the database (to the users table) from what I can see, the email address can be decoded on the backend if it is in base64, from which the user can then be found. The only problem is that base64 isn't really encrypted off course, but at least it will hide the email address from most bots that way.

If md5 was used, you would either need to query all the users in the database and compare the md5 of the email address for each user, with the hash from the url (which can be expensive if there are lots of users and probably won't scale well)... unless you added an extra column with the hash of the email for each user, so that can be used as a lookup.

I think base64 is probably the easiest solution to implement.

I would recommend to remove the e-mail address from the user profile and replace it with a link to a website, which the user may optionally provide.

Also simply try to lookup the username from the database and if there is no such user, just simply write the name there. At least thats the behaviour other code hosting platforms seem to use. In case this gets a performance issue, you could still cache it in memcache or something.

@sts Gogs is not a public code hosting, it does not has large user base to match the user name, so the e-mail address I believe is the best identity to match.

But currently you try to link to a user profile, which doesn't exist, because the function is simply trying to use the e-mail address. Links without valid targets are confusing users.

Given invalid user name will point to 404 as well.

Yes, my point was to show the user's name but not link it. If you try to lookup the e-mail address, and it doesn't exist in the database, you cannot show a user profile and you don't need to put a link there.

Besides that it resolves the issue with exposing e-mail addresses as well. I was just trying to get the feature a bit more clear from a users point of view as well. :-)

I would prefer check e-mail and disable link if not exist, user name isn't more reliable than e-mail address in my opinion.

OK u think u could help me out cuz I have the same problem

OK, now I check e-mail in database, if exists, then given link of user profile page; if not, disable the link style. So now, there is no e-mail address available in this page any more.

Feel free to test it: https://try.gogs.io/Unknown/gogs/commits/dev

Notification email contains email addresses of all recipients in the To: field. This can be annoying when number of watchers increase. Some SMTP servers even reject emails where number of recipients exceed a limit. These emails should be sent separately one-by-one or in configurable chunks. See Postfix configuration:

smtpd_recipient_limit (default: 1000)
The maximal number of recipients that the Postfix SMTP server accepts per message delivery request.

http://www.postfix.org/postconf.5.html#smtpd_recipient_limit

Is googlecode's issue tracker approach relevant?
For example, sya...@google.com, nick.l...@gmail.com

Notification email contains email addresses of all recipients in the To: field. This can be annoying when number of watchers increase. Some SMTP servers even reject emails where number of recipients exceed a limit. These emails should be sent separately one-by-one or in configurable chunks. See Postfix configuration:

@kolesar-andras you want to have a config option that limits the maximum recipients in a single email?

Yes, exactly. I would prefer to set it to 1, sending each notification individually. Others may leave it empty, keeping all recipients in a single email. Default may be 1000 or below to be compatible with at least Postfix out-of-the-box.

@linquize you can't obfuscate email addresses in an email. If you send email to sya...@google.com it will not reach the intended recipient.

@kolesar-andras you want to have a config option that limits the maximum recipients in a single email?

@kolesar-andras Please rise another issue for this specific purpose.