Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Ability to attach files to issues (attachments) #307

Merged
merged 12 commits into from Jul 24, 2014
Merged

Feature: Ability to attach files to issues (attachments) #307

merged 12 commits into from Jul 24, 2014

Conversation

nussjustin
Copy link
Contributor

This fixes #304.

Add the ability to add attachments to issues/comments.
A new button was added below the text area of comments/issues, which allows the upload of multiple files.

Files get listed below the text of an issue/comment. Hovering over the files gives a little preview (for images).
If an issue/a comment gets deleted the files attached get deleted too.

There are 4 5 new config values that controll the uploads. (under [attachment])

I'm not good with styling, so the CSS should probably be adjusted :-)
Here an little image:

attachments

@nussjustin
Copy link
Contributor Author

Update: Could this wait a minute? I'm just testing a missing option ^^

@unknwon
Copy link
Member

unknwon commented Jul 24, 2014

Sure.

@nussjustin
Copy link
Contributor Author

Ok, new commit is in :-)
It can be reviewed/merged now.

Update: After this, could the try.gogits.com site be updated?
It would probably be better to have the new changes there, so that everyone can test these (attachments could be disabled if not desirable)

unknwon
unknwon reviewed Jul 24, 2014
View reviewed changes
models/issue.go
IssueId int64
CommentId int64
Name string
Path string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think add tag xorm:"TEXT" would be better in case file path is longer than 255

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can do that when I'm home.

@nussjustin
Copy link
Contributor Author

Feld geupdated.

@unknwon
Copy link
Member

unknwon commented Jul 24, 2014

No problem~

unknwon added a commit that referenced this pull request Jul 24, 2014
@unknwon
Merge pull request #307 from nuss-justin/feature/attachments
da0240a 
Feature: Ability to attach files to issues (attachments)
@unknwon unknwon merged commit da0240a into gogs:dev Jul 24, 2014
@unknwon
Copy link
Member

unknwon commented Jul 24, 2014

Seems like only allow 1 attachment for each comment right now?

@unknwon
Copy link
Member

unknwon commented Jul 24, 2014

BTW, it's working, perfect!

@unknwon
Copy link
Member

unknwon commented Jul 24, 2014

Demo site is now running with latest commit on dev branch!

@nussjustin
Copy link
Contributor Author

That's good to hear :-)
That means I can add the next feature without thinking about this.

@unknwon
Copy link
Member

unknwon commented Jul 24, 2014

You're rocking!

@nussjustin
Copy link
Contributor Author

No worry, next PR will be there in a minute ;-)

@acusti acusti mentioned this pull request Jul 24, 2014
Closed
@nussjustin nussjustin deleted the feature/attachments branch July 26, 2014 09:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nussjustin @unknwon @nussjustin-hmmh