Aha, thanks all your previous PRs!

What's the state of commits in the database?

Commits are not saved in database, the only time you can reach if the commit message contains somethings like fix #xx the in https://github.com/gogits/gogs/blob/dev/models/action.go#L82

My thought was, that there is a CommitId field on the Commit struct, but it always gets 0. How is it intended to be used? I though I could create a comment with CommitId referencing the commit that contains the fix #xx message, but it doesn't have an identifier (except the commit hash, but the database column is of type bigint)

Update: My idea is to change the CommitId of the Comment struct to a String and then save a commit hash in it. This way we could link to the commit.

If pull requests get implemented, the field can then act as either a reference to a commit in the pull request or as closing commit. (This could depend on the Type of the comment)

CommitId is prepared for comments on the diff/commit page like https://github.com/nuss-justin/gogs/commit/469cbc881340dd , so for issue it's always 0...

It was just an thought :-)
I wanted to add the commit (of the commit that closes the issue) to the comment, in the IT_CLOSE case, so it can be shown in the issue.

I could use the Content of the comment, for the commit message, but I would also need to store the commit hash somehow.It was just an thought :-)
I wanted to add the commit (of the commit that closes the issue) to the comment, in the IT_CLOSE case, so it can be shown in the issue.

I could use the Content of the comment, for the commit message, but I would still also need to store the commit hash somewhere.

I think we might just need more types for two following usage:

Yeah, that should be easy (just adding two new consts) for the types.
But for the 2. one it should also be able to reference a commit directly like this:

It should either be another new type or something else to distinguish between references from other issues and commits.

It should either be another new type or something else to distinguish between references from other issues and commits.

type ReferenceType int

const (
 PULL ReferenceType = iota + 1
 ISSUE
 COMMENT
)

Add a refType field to distinguish?

I see two ways to solve this:

Solution 1: We could use your suggestion and add a ReferenceType type, which could look like this:

type ReferenceType int

const (
 // Reference from some pull request
 PULL ReferenceType = iota + 1

 // Reference from another issue
 ISSUE

 // Plain old comment
 COMMENT

 // Reference from some commit (not part of a pull request)
 COMMIT
)

Solution 2: We could just combine the ReferenceType with the existing IT_* types (used as Comment.Type values) like this (see comments):

type CommentType int

const (
 // We use iota and the order COMMENT, REOPEN, CLOSE to maintain
 // backwards compatibility with existing comments, without updating them

 // Plain old comment, can be associated with a commit (CommitId > 0) and a line (Line > 0)
 COMMENT CommentType = iota

 // Reopen action
 REOPEN

 // Close action
 CLOSE

 // Reference from another issue
 // Maybe with some prefix/suffix to show that it's a reference,
 // like ISSUEREF or something similar
 ISSUE 

 // Reference from some commit (not part of a pull request)
 COMMIT

 // Reference from some pull request
 PULL
)

Personally I like the 2. one more, because it only needs one type, and maintains backwards compatibility, without having to update anything. (Except I'm missing something)

One thing I'm still not sure how to implement is the case when a normal commit references (closes) an issue. In this case we need 1. the commit message (to be shown on the issue page) and it's hash (so that we can link to it). The message can be saved inside the normal Comment.Content field, which is otherwise only used by normal comments.

Now the hash has to be saved somewhere too. It could be put in the Comment.Content field too, but I would rather have it stored in another column or table.

One thing I'm still not sure how to implement is the case when a normal commit references (closes) an issue. In this case we need 1. the commit message (to be shown on the issue page) and it's hash (so that we can link to it). The message can be saved inside the normal Comment.Content field, which is otherwise only used by normal comments.

Just make a ISSUE_COMMENT in CommentType should be fine?

My problem is not the type.
The Comment would just look like:

Comment {
    // ...
    Type: <ISSUE, COMMIT or PULL>
    Content: <COMMIT MESSAGE>
    // ...
}

but the commit hash must be stored too

I thought about putting it directly into the message (<a href="<URL>/<HASH>"><MESSAGE></a>), but I don't know if this is really what we want.

If we don't need access that commit hash anywhere else, then store in message is fine.

I've made a pull request to test/review my changes: #305

Sorry, how does code work?

I tried to push commit with message fix #1 but seems like nothing happened? Did u forgot to add new comment when detected?

I just tested it with my local branch (the one merged) and the current gogits/gogs dev branch.

This is what I did in both cases (not exactly the same thing):

And this is what i got on the current dev branch:

I get the same with my local branch. It searches for the same words as Github. (https://help.github.com/articles/closing-issues-via-commit-messages) followed by the issue as either #XXX or user/repo#XXX (it doesn't search for only user#XXX at this time)

Really? I did same thing but nothing happens?

I just created a fresh gogs server on a linux vServer and everything worked as expected (except a little counter bug, which I'm now gonne to pull-request in :-))

Update: Image

so wried ...

Hey, have you tested it again?
I'd like to know if this now works as expected, so that this issue can be closed.

I'll test again later and look at the code.

Sorry for late, it's working!

No problem :-)