New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack Support #379
Slack Support #379
Conversation
Thanks your PR! It's quite a lot changes, look good so far. But I would recommend to modify |
Great thanks! Ah yes... I was thinking those css files were generated, but for some reason I never stumbled onto the less files in my searching ... doh! I've rebased now and made those changes. |
This PR involves a lot changes, I have to take a little time to go through. |
Sure! Yeah even I didn't think as many changes would be needed when I started, but hopefully adding additional hooks should be more flexible now. Glad to make any additional changes. Still very new to go myself. |
I believe your code is working, but just for reviewing some design pattern. |
ContentType: w.ContentType, | ||
IsSsl: w.IsSsl, | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case can be deleted because Gogs is the default
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah good point. On it.
Other than that looks good, please resolve the conflicts then re-PR. I'll merge it as one of 0.5 release feature! |
Okay all set! Thanks for reviewing. Also as a heads-up - I have one more PR which compares two commits that I will submit in once this is merged. |
Thanks! |
I'm getting this error in template: |
I don't know why, but suddenly worked. |
Looks prefect! |
I've pushed a mirror fix for file name from |
I have noticed that the Slack webhook fails with the following message:
I did a Edit: This is totally on me. I, of course, had a space at the start. I am leaving this up just in case anyone is as silly as me. |
@drwlrsn I think it is because you have a space in the input field? |
does the current slack support push issues to slack? it only seems to deal with commits. TIA |
@dansteingart , no it does not.. |
@unknwon OK thanks. I'll try to hack the planet and see if I can get it to happen |
Sorry for digging this up again, but would it be possible to make the messages pushed to Slack localizable - or even better, customizable? Currently, they are hard coded in english. It would be nice to have translations here or the possibility to set the strings using variables in the Gogs admin area. |
@Radiergummi good idea... please file another issue for this suggestion! |
Hi,
I've added Slack webhook support. I needed to make a few changes to better support different hook types. In addition, I fixed one existing bug that caused all webhooks to be updated when updating a single webhook (first commit).
Please let me know if you see any changes needed.
Closes #292
Once this is merged, I have another PR to submit to allow comparing two different commit sha1s (one of the TODOs in here)