check enablesXDR option when Request.hasXDR is called just in case #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ var Blob = require('blob'); | |||
| require('./engine.io-client'); | |||
| require('./socket'); | |||
| require('./transport'); | |||
| require('./transports'); | |||
There was a problem hiding this comment.
The XDR test should be included in the browser only section (under if (env.browser))
|
Better safe than sorry. Great work. :) |
|
@rase- Thanks for your comments ;) I moved the transports test to browser only section. |
|
Looks good. Awesome work. :) |
rase-
added a commit
that referenced
this pull request
Aug 20, 2014
check enablesXDR option when Request.hasXDR is called just in case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fix to primus/primus#282 together with #333.
It should work without this fix because IE8 uses jsonp-polling when enablesXDR is false, but this way makes more sense, and possibly avoid bugs in future.