New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 should use XDomainRequest to avoid loading bar flashing #331
Conversation
This PR is incredibly solid. |
IE8 should use XDomainRequest to avoid loading bar flashing
This PR should henceforth be referred to as the mother of all PRs. |
@guille Thanks you!! |
You need to provide a way to turn this off as xdomainrequest is severely flawed. (Not sending cookies etc) |
In #217 we removed this functionality for a reason. I personally would rather see a working connection with a loading bar then a dead connection. |
Should I create a new PR not to use XDR as default and provide an option to enable it? |
OK, I closed #332 then. |
Using the |
OK, I did. #333 |
....i have a probelm , it's about ie 6 7 8 loading bar flashing , my socket.io version 1.3.6 and when i run socket connect from a Static simple.html .the code : |
fix socketio/socket.io#1671