Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoConnect option #728

Merged
merged 1 commit into from Jul 16, 2014
Merged

Fix autoConnect option #728

merged 1 commit into from Jul 16, 2014

Conversation

nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Jul 12, 2014

We have to remove Manager#open method call for the autoConnect option.

I'm not sure whether should check autoConnect is enabled like the following:

if (false !== this.io.opts.autoConnect) {
  this.io.open(); // ensure open
}

@rauchg
Copy link
Contributor

rauchg commented Jul 14, 2014

I think we should, otherwise it won't connect for the cases where we call .disconnect on all the namespaces, the underlying engine connection gets closed, but then you attempt to open a new namespace. In that case it should re-open the underlying transport, which it won't with this change.

I also think we should add a testcase for that situation.

@nkzawa
Copy link
Contributor Author

nkzawa commented Jul 15, 2014

@guille I improved and rebased the commit. Please check it.

rauchg added a commit that referenced this pull request Jul 16, 2014
@rauchg
Merge pull request #728 from nkzawa/patch-8
6ad719e 
Fix autoConnect option
@rauchg rauchg merged commit 6ad719e into socketio:master Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkzawa @rauchg