Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache remote address in handshake since it might be lost later. #270

Merged
merged 1 commit into from Jul 19, 2014
Merged

Cache remote address in handshake since it might be lost later. #270

merged 1 commit into from Jul 19, 2014

Conversation

rase-
Copy link
Contributor

@rase- rase- commented Jul 19, 2014

For the Socket.IO handshake address property.

@rauchg
Copy link
Contributor

rauchg commented Jul 19, 2014

I think the Socket constructor could do this itself, since it receives the req parameter.

@rase-
Copy link
Contributor Author

rase- commented Jul 19, 2014

True. Will move it.

@rase-
Copy link
Contributor Author

rase- commented Jul 19, 2014

Moved.

rauchg added a commit that referenced this pull request Jul 19, 2014
@rauchg
Merge pull request #270 from rase-/cache-ip-in-handshake
f00ef8b 
Cache remote address in handshake since it might be lost later.
@rauchg rauchg merged commit f00ef8b into socketio:master Jul 19, 2014
darrachequesne pushed a commit that referenced this pull request May 8, 2020
@rauchg
Merge pull request #270 from j-salazar/noping
44b3573 
Don't ping when socket closed by open handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rase- @rauchg