Close sio #1646

narcisoguillen · 2014-06-24T01:08:40Z

When creating a new Server with a port

var PORT = 3030;
var sio = require('socket.io')(PORT);

socket.io is creating a new http server https://github.com/Automattic/socket.io/blob/master/lib/index.js#L209 when only sending a PORT. This will allow to close this server

Currently

var PORT = 3030;
var sio = require('socket.io')(PORT);

sio.engine.close();

var sio = require('socket.io')(PORT);

  Error: listen EADDRINUSE

Lordnibbler · 2014-06-24T01:14:15Z

👍 for this fix, been missing the close() method in 1.0!

rauchg · 2014-06-24T01:14:37Z

Looks really good, thanks. Definitely needs tests

rauchg · 2014-06-30T17:15:44Z

test/socket.io.js

+  describe('close', function(){
+
+    it('should be able to close sio sending a srv', function(){
+      var PORT   = 3030;


This could technically be used on someone's machine. We need to use ephemeral ports in tests.

Close sio

Narciso Guillen added 2 commits June 23, 2014 19:55

make sure server gets close

fbdb94d

Update README

2e8e266

Narciso Guillen added 2 commits June 23, 2014 21:03

Add ability to stop the http server even if not created inside socket.io

968105a

Add close specs

a1feca1

rauchg reviewed Jun 30, 2014
View reviewed changes

Narciso Guillen added 2 commits June 30, 2014 15:49

use ephemeral ports

4b89bce

Improve Close documentation

1f7da93

rauchg added a commit that referenced this pull request Jul 1, 2014

Merge pull request #1646 from narcisoguillen/close_sio

c18ed5f

Close sio

rauchg merged commit c18ed5f into socketio:master Jul 1, 2014

Provide feedback