server: fix ws memory leak (fixes #268)

socketio · Jul 30, 2014 · 01e173c · nicokaiser · Jul 30, 2014 · rase-
1 parent f00ef8b
commit 01e173c
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/server.js b/lib/server.js
@@ -49,7 +49,7 @@ function Server(opts){
   if (~this.transports.indexOf('websocket')) {
     this.ws = new WebSocketServer({ noServer: true, clientTracking: false });
   }
-};
+}
 
 /**
  * Protocol errors mappings.
@@ -268,7 +268,7 @@ Server.prototype.handshake = function(transport, req){
  * @api public
  */
 
-Server.prototype.handleUpgrade = function(req, socket, head){
+Server.prototype.handleUpgrade = function(req, socket, upgradeHead){
   this.prepare(req);
 
   var self = this;
@@ -278,8 +278,12 @@ Server.prototype.handleUpgrade = function(req, socket, head){
       return;
     }
 
+    var head = new Buffer(upgradeHead.length);
+    upgradeHead.copy(head);
+    upgradeHead = null;
+
     // delegate to ws
-    self.ws.handleUpgrade(req, socket, head, function(conn){
+    self.ws.handleUpgrade(req, socket, upgradeHead, function(conn){
       self.onWebSocket(req, conn);
     });
   });