New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out a better solution for extra scrollbars in IE #3364
Comments
Originally by @Artur- Attachment added: |
Originally by RalfN Don't know, if it's helpful, but adding .box:after { removes some of the scrollbars. And FF and chrome don't complain about this. greetings |
Originally by fcracker79 It may be trivial, but one might add the following: padding-bottom: 0.3em; to the container class and at least the bar disappears. Maybe it could be included only for Internet Explorer 8, even though this way users may notice different rendering results in IE compared to Firefox. |
Originally by RalfN Any updates on this one? |
Originally by @jouni The new Valo theme currently works around this issue with the following main ingredients:
So far it's looking good, no font-size: 0; or line-height: 0; hacks necessary. But I will not say it's bulletproof just yet. I'll wait for a larger beta test audience to tell me otherwise. |
Originally by santeriv-profit Jouni, thanks a lot for quick reaction, seems to solve vertical extra scrollbars on IE10 at least. Here is how I used it with .css in Vaadin 7.2.0
I don't know if this style-fix needs MSIE-only-guard?
|
Originally by @jouni No need for any IE guards, the fix is applied to all browsers in Valo also. The issue affects all browsers, not just IE (at least in Valo to some degree), but for some reason it was only evident in IE with the older themes. And do use the child combinator ( I would say it's pretty safe to just make it into a global fix, but if you absolutely want to scope it with an additional style name, go ahead. So I would just add this in your theme:
Or if you prefer to scope it, then this:
|
Closing as wontfix, as all old themes will be deprecated in version 8. You can use the documentation workarounds in this issue for your custom themes. |
Originally by @Artur-
IE8-IE10 adds extra scrollbars when a container div with "overflow: auto" contains one or several inline blocks which either
a) contains no text node
or
b) has overflow: hidden
The extra scrollbars in the parent come from extra spacing being reserved by IE below the last inline block. The size of the spacing is relative to the font-size, for a 20px font-size (on the body) the spacing is 6px. Increasing the font-size to 50px increases the spacing to 13px.
The current workaround for this is to define font-size:0 for all v-scrollables which makes the extra spacing 0 and removes the unnecessary scrollbars. To compensate for this all root widget elements (v-widget) define font-size: $font-size, where $font-size is defined for the theme.
This approach makes using em:s and relative (%) font-sizes impossible for the root element in widgets, as these would be relative to the parent element font-size, which is 0. It also makes specifying layout and widget sizes impossible using em:s (percentages work fine) as em:s in sizes are also relative to the parent font-size.
The text was updated successfully, but these errors were encountered: