Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridLayout does not position items in columns correctly #5524

Closed
vaadin-bot opened this issue Aug 7, 2014 · 4 comments
Closed

GridLayout does not position items in columns correctly #5524

vaadin-bot opened this issue Aug 7, 2014 · 4 comments
Labels

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @snyholm


Gridlayout positions items incorrectly. Items in the same column but on different rows get shifted horizontally. In 7.1.15 they are placed correctly. Test case included, you can see the old behavior in it by switching the Vaadin version.

Expected behavior : Items in the same column start at the same horizontal position.
Actualy behavior : Items start at odd places.


Imported from https://dev.vaadin.com/ issue #14392

@vaadin-bot
Copy link
Collaborator Author

Originally by @snyholm


Attachment added: GridBugTest.zip (13.0 KiB)

@vaadin-bot
Copy link
Collaborator Author

Originally by Markus Koivisto


Works in 7.2.2 still. Behaviour modified by the patch for http://dev.vaadin.com/ticket/8855.

@vaadin-bot
Copy link
Collaborator Author

Originally by Markus Koivisto


The problem here is that empty rows/column are no longer sent to the client, as per the discussion for #8855.

To be specific, the issue is not "Items in the same column but on different rows get shifted horizontally." The issue is that "items in the same column but in a different gridlayout with the same total width don't start at identical places."

@vaadin-bot
Copy link
Collaborator Author

Originally by Markus Koivisto


We're evaluating several ways to fix this in a way that would still solve #8855 in a reasonable way. One of the stronger candidates would be to introduce a mode variable for the "cleanup" behaviour that hides empty rows/columns.

@vaadin-bot vaadin-bot added the bug label Dec 10, 2016
@vaadin-bot vaadin-bot added this to the Vaadin 7.3.0.rc1 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant