Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VWindowOverlay #5330

Closed
vaadin-bot opened this issue Jun 19, 2014 · 2 comments
Closed

Remove VWindowOverlay #5330

vaadin-bot opened this issue Jun 19, 2014 · 2 comments
Labels
bug
Milestone
Vaadin 7.3.0.beta1

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @Artur-

VWindowOverlay was added in 00c473a / #11821 without any explanation of why it exists. It only contains two methods which create an extra overlay div in addition to the one alreday created by VOverlay, polluting the DOM.

It should be removed unless there is a very good reason that it exists.

Imported from https://dev.vaadin.com/ issue #14055
@vaadin-bot
Copy link
Collaborator Author

Originally by @Artur-

Would make sense to include this in 7.3 if it does not cause any issues.

@vaadin-bot
Copy link
Collaborator Author

Originally by @hesara

Causes a test failure that is partly related to #13885/#9303.

To be merged after those have been fixed.

@vaadin-bot vaadin-bot added the bug label Dec 10, 2016
@vaadin-bot vaadin-bot added this to the Vaadin 7.3.0.beta1 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Vaadin 7.3.0.beta1
Development

No branches or pull requests
1 participant
@vaadin-bot