Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename v-app-background-color to v-background-color in Valo #5125

Closed
vaadin-bot opened this issue Apr 28, 2014 · 0 comments
Closed

Rename v-app-background-color to v-background-color in Valo #5125

vaadin-bot opened this issue Apr 28, 2014 · 0 comments

Comments

@vaadin-bot
Copy link
Collaborator

Originally by @jouni


Currently $v-app-background-color is used for many color computations directly. The .v-app element's background color should be parametrized, but there should also be the top-level variable which is used as the default for all component background colors.

E.g.

$v-background-color: #fff !default;
$v-app-background-color: $v-background-color !default;
$v-button-background-color: $v-background-color !default;

etc.

Imported from https://dev.vaadin.com/ issue #13670

@vaadin-bot vaadin-bot added this to the Vaadin 7.3.0.alpha3 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant